-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Moved web assets to web/ and implemented a pure PHP compression solution for CSS and JS files #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"%kernel.root_dir%/Resources/assets/js/bootstrap-3.3.4.min.js" | ||
"%kernel.root_dir%/Resources/assets/js/highlight.pack.js" %} | ||
{# uncomment the following lines to combine and minimize JavaScript assets with Assetic | ||
{% javascripts filter="jsqueeze" output="js/app.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ?jsqueeze
to apply the minification only in non-debug mode
I'm not sure about merging this change. I'd love to hear first the opinions of @weaverryan and @wouterj about it. They both know this topic well and they seem to have strong opinions about it (and definitely more qualified than mine!) |
@weaverryan ping as there was a typo when mentioning you previously @wouterj any opinion on this ? |
|
This PR is ready for the final review:
The result is that:
|
@javiereguiluz it would be great to provide a way to recompile the assets for contributors (using |
@javiereguiluz I suggest putting this in CONTRIBUTING.md instead, to follow the github conventions |
This fixes #5