Remove unnecessary historic configuration: 'sudo: false' #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope I did enough Googling. I really tried to find a reason to keep `sudo :false` in 2020 but it seems that it has no effect anymore. I even tried to `sudo echo foo` during Travis' `install` phase and that works with and without `sudo: false`. Docs: https://docs.travis-ci.com/user/reference/overview/#deprecated-virtualization-environments Blog post stating "If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration soon": https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
rosier
approved these changes
May 17, 2020
|
Thanks Michael. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I did enough Googling. I really tried to find a reason to keep
sudo :falsein 2020 but it seems that it has no effect anymore.I even tried to
sudo echo fooduring Travis'installphase and that works with and withoutsudo: false.Docs: https://docs.travis-ci.com/user/reference/overview/#deprecated-virtualization-environments
Blog post stating "If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration soon": https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
I also created a PR for the Symfony docs: symfony/symfony-docs#13675