Skip to content

Added some missing labels in configuration blocks #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

javiereguiluz
Copy link
Collaborator

In addition to the main fix, I made another change in this PR.

The current labels for "php-symfony" and "php-standalone" are "Framework Use" and "Standalone Use". I don't think they are bad, but they could be better.

In this PR I propose to use "Symfony apps" and "Standalone PHP apps". Here's a comparison:

image

I like "Symfony apps" a lot but I don't like "Standalone PHP apps" the same. Maybe "Other PHP apps", "Non-Symfony apps", ... ? Or maybe the original labels are better and we should keep them?

What do you think @weaverryan, @wouterj? Thanks!

@OskarStark
Copy link
Contributor

OskarStark commented Mar 31, 2021

With Framework or With the Framework

Without Framework or Without the Framework ?

Or Framework / No Framework?

@javiereguiluz
Copy link
Collaborator Author

Please, don't forget to add your suggestions here. Thanks!

@javiereguiluz
Copy link
Collaborator Author

I've reverted the proposed label renames to make this mergeable and we can discuss about renaming in the future.

@weaverryan weaverryan merged commit 06fbd81 into symfony-tools:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants