Made the counting of code lines more robust #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to trim the codeblock before highlighting rather than after. In this html-twig.html, the final LF char is before the |
|
@stof your suggestion fixed the problem! Thanks a lot! |
nikophil
approved these changes
Mar 26, 2021
|
Awesome - thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some issues in the counting of lines in some generated docs ... so this PR tries to make things more robust.
As you can see in tests, we remove a trailing new line in some code blocks. This is correct, because new lines inside
<pre>are significant. So, this is a bug fix in those cases.Update: the following error was fixed thanks to Christophe's suggestion. Thanks!
However, there's a problem with these tests:tests/fixtures/expected/blocks/code-blocks/html-twig.htmltests/fixtures/expected/blocks/code-blocks/twig.htmlI had to update those tests to fix them, but this is wrong. The extra line added to the generated HTML is wrong. I can't see why this happens. Can anyone help me? Thanks!