Fixed the handling of custom image prefix #86
Conversation
| if ('' === $this->buildConfig->getImagesPublicPrefix()) { | ||
| $newUrlPath = $node->getEnvironment()->relativeUrl('_images/'.$fileInfo->getFilename()); | ||
| } else { | ||
| $newUrlPath = $this->buildConfig->getImagesPublicPrefix().'/'.$fileInfo->getFilename(); |
There was a problem hiding this comment.
Hii @javiereguiluz
we're copying the image to $this->buildConfig->getImagesDir().'/'.$fileInfo->getFilename() but we're linking to $this->buildConfig->getImagesPublicPrefix().'/'.$fileInfo->getFilename()
isn't there a problem if these two paths are uncorrelated?
in the test below, the img's src is /some/custom/prefix-for-images/symfony-logo.png but the image file path is ./_images/symfony-logo.png
There was a problem hiding this comment.
You are right. However, this is intended.
The default behavior is unchanged (copy images in <contents/_images/ and link to them in that dir using a relative link). However, for advanced/custom setups, the images are copied to a separate dir (or even server/service like AWS). The missing piece that you mentioned is that in your own code using this Doc Builder you must take care of this and copy/move the images accordingly.
|
A test is included... so I'm happy with this if it gives us the end result we need :) |
I introduced some issues when refactoring this. The new proposed logic is:
<your prefix> + / + <image relative path>(we don't change that URL to a relative one to avoid issues ... we use your provided prefix "as is")<output dir>/_images/and calculate image URLs as relative URLs.