Tweaked the configuration block directive #85
Conversation
javiereguiluz
force-pushed
the
configuration_block
branch
from
cfdccc4 to
8e5bacb
Compare
|
Sorry for the continuous changes in the proposed HTML code. I'm happy with the latest result, so I don't plan to change this for now ... so this can be reviewed. Thanks! |
| <ul class="configuration-tabs"> | ||
| <li data-language="YAML" data-active="true"> <span>YAML</span> </li> | ||
| <li data-language="XML" > <span>XML</span> </li> | ||
| <li data-language="PHP" > <span>PHP</span> </li> |
There was a problem hiding this comment.
- <li data-language="PHP" > <span>PHP</span> </li>
+ <li data-language="PHP"><span>PHP</span></li>Do we really need to generate these spaces?
There was a problem hiding this comment.
I'd prefer to keep it (it's the same case as https://github.com/weaverryan/docs-builder/pull/56#issuecomment-791463260).
I know some people disagree but ... I prefer to make templates readable instead of making the generated HTML perfect, because templates are for humans (and they must maintain them in the future) and HTML is for machines and they don't care.
I hope you agree somewhat on this 🙏
There was a problem hiding this comment.
👍 to be pragmatic on this kind of things
|
Thanks Javier! |
Configuration blocks weren't styled yet in the new doc builder, so I did that and to make CSS and JS code much easier, I propose this tweaks in the generated HTML code for them.