Skip to content

Mark external links as unsafe #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

javiereguiluz
Copy link
Collaborator

This follows the best practices about linking to external sites. See Google's guide about Links to cross-origin destinations are unsafe.

It also allows to apply different styles to external/unsafe links:

image

@weaverryan weaverryan merged commit 93d3230 into symfony-tools:master Mar 19, 2021
@weaverryan
Copy link
Contributor

Thanks Javier!

@javiereguiluz javiereguiluz deleted the safer_external_links branch March 19, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants