Adding a failing test case for bad figure behavior #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Mar 19, 2021
| if (null === $document) { | ||
| throw new \RuntimeException('Content expected, none found.'); | ||
| } | ||
|
|
There was a problem hiding this comment.
A little extra thing - admonitions (notes, etc) MUST have content. For example, this is illegal:
.. note::
I forgot to indent a message on my note! I'm *note* having a good day ;)
weaverryan
commented
Mar 19, 2021
| <body> | ||
|
|
||
| <figure> | ||
| <!-- REMOVE: src is empty just because the test doesn't utilize the full stack, with CopyImagesListener --> |
There was a problem hiding this comment.
I really wanted to document why the src= is empty. Making it ACTUALLY work would be a lot more work to make the test much more complex, and I don't think it's worth it (I'm pretty sure the images and image paths are tested elsewhere).
weaverryan
force-pushed
the
figure-test-case
branch
from
5e28a03 to
bba9e6d
Compare
wouterj
approved these changes
Mar 22, 2021
weaverryan
commented
Mar 23, 2021
| @@ -12,8 +12,8 @@ <h1 id="toctree"><a class="headerlink" href="#toctree" title="Permalink to this | |||
| <div class="toctree-wrapper"><ul class="toctree toctree-level-1 toctree-length-1"><li><a href="file.html">Title</a><ul class="toctree toctree-level-2 toctree-length-1"><li><a href="file.html#sub-title">Sub title</a></li></ul></li></ul></div> | |||
| <div class="toctree-wrapper"><ul class="toctree toctree-level-1 toctree-length-1"><li><a href="file.html">Title</a></li></ul></div> | |||
| <div class="toctree-wrapper"><ul class="toctree toctree-level-1 toctree-length-1"><li><a href="directory/another_file.html">Another file</a></li></ul></div> | |||
| <div class="toctree-wrapper"><ul class="toctree toctree-level-1 toctree-length-3"><li><a href="index.html#toctree">Toctree</a></li><li><a href="directory/another_file.html">Another file</a></li><li><a href="file.html">Title</a><ul class="toctree toctree-level-2 toctree-length-1"><li><a href="file.html#sub-title">Sub title</a></li></ul></li></ul></div> | |||
| <div class="toctree-wrapper"><ul class="toctree toctree-level-1 toctree-length-3"><li><a href="file.html">Title</a><ul class="toctree toctree-level-2 toctree-length-1"><li><a href="file.html#sub-title">Sub title</a></li></ul></li><li><a href="index.html#toctree">Toctree</a></li><li><a href="directory/another_file.html">Another file</a></li></ul></div> | |||
There was a problem hiding this comment.
caused by fixes upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65
Failing test cases for #65 - but it's actually fixed in doctrine/rst-parser#141
Also updated
doctrine/rst-parserto latest 0.4 branch version.