Adding a span around code blocks that start with $ #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's make it a bit more difficult Ryan 😉. The python terminal lexer we're using also takes care of some other (windows & comments) highlights: https://github.com/symfony/symfony-docs/blob/5.x/_build/_exts/symfonycom/sphinx/lexer.py |
Oh, boooooo. You got me Wouter! 😆 |
|
Ok, should be better now. This may not imitate exactly what the old one does. But... we can basically do whatever we want. The test case holds all the scenarios and markup... and we can add more - https://github.com/weaverryan/docs-builder/pull/78/files#diff-ffe40345fc14908fa9ef0846da05ce80b3398903e81e02c5363c21451346adea |
javiereguiluz
approved these changes
Mar 19, 2021
|
Yay! And if we need further tweaks, as you can see, it should be easy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68