GitHub auto release #25
Conversation
src/Command/GithubReleaseCommand.php
Outdated
| $dotenv = new Dotenv(); | ||
| $dotenv->load(__DIR__.'/../../.env'); | ||
|
|
||
| if (empty($_ENV['GITHUB_API_TOKEN'])) { |
There was a problem hiding this comment.
For some edge-case reason, I'm told we should use $_SERVER for env vars :)
src/Command/GithubReleaseCommand.php
Outdated
| use Symfony\Component\Process\Process; | ||
| use Symfony\Contracts\HttpClient\HttpClientInterface; | ||
|
|
||
| class GithubReleaseCommand extends Command |
There was a problem hiding this comment.
Having a command to release a command-line library feels weird to me - there's no reason, for example, that this should even been accessible when you're working with the phar file. Could we make this a flat bin/create_release file? We would still require the autoloader... and then probably we could refactor some of the code into "service classes" that are used in that script (so that the script is ultimately tiny). We could then not include this script nor those supporting classes in the phar file.
src/Command/GithubReleaseCommand.php
Outdated
| $this->client = $this->createHttpClient($_ENV['GITHUB_API_TOKEN']); | ||
|
|
||
| $tag = $input->getArgument('tag'); | ||
| if (!preg_match('/^v\d+\.\d+\.\d+$/', $tag)) { |
src/Command/GithubReleaseCommand.php
Outdated
| $message = 'Maybe the tag name already exists?'; | ||
| } | ||
|
|
||
| throw new RuntimeException(sprintf('Error while trying to create release: %s.', $message), 0, $exception); |
src/Command/GithubReleaseCommand.php
Outdated
| 'target_commitish' => 'master', | ||
| 'name' => $this->name, | ||
| 'description' => $this->description, | ||
| 'draft' => false, |
There was a problem hiding this comment.
Hmm. Could we set this draft => true, then upload the asset, then modify it to draft=>false? That's minor... but it would eliminate any time when the release is published and has no phar attached.
composer.json
Outdated
| "twig/twig": "^2.7.3" | ||
| "twig/twig": "^2.7.3", | ||
| "symfony/http-client": "^4.3", | ||
| "symfony/dotenv": "^4.3" |
nikophil
force-pushed
the
github-auto-release
branch
from
fc65e19 to
a2892cd
Compare
nikophil
force-pushed
the
github-auto-release
branch
from
a2892cd to
cbe535d
Compare
No description provided.