Avoid link with same ID's #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Mar 25, 2023
javiereguiluz
approved these changes
Apr 4, 2023
|
New issue opened symfony/symfony-docs#18194 Merging this PR will be very cool 😃 |
OskarStark
reviewed
Apr 13, 2023
| class TitleNodeRenderer implements NodeRenderer | ||
| { | ||
| /** @var TitleNode */ | ||
| private $titleNode; |
There was a problem hiding this comment.
@javiereguiluz can we use typed properties?
There was a problem hiding this comment.
Let's check that ... but do it in other PR so we can merge and deploy this one as soon as possible. Thanks.
javiereguiluz
force-pushed
the
not-multiple-id
branch
from
ee4e64f to
048f43e
Compare
|
Thanks Antoine! Let's now tag a new version and deploy it in production so these issues can be fixed soon. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR try to generate unique link id.
Relative issues in symfony docs:
symfony/symfony-docs#16417
symfony/symfony-docs#16721
rst-parser instantiate NodeRenderer for each node so the only way I found is to use static property and save when id is already rendered on same page.
Examples of changes on symfony-docs:
alamirault/sf-doc-output@45a5281