fix: escape special chars in code text #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/escape-in-text-code
branch
from
dae4c79 to
3407885
Compare
nikophil
commented
Dec 29, 2022
| @@ -117,23 +118,6 @@ public static function isLanguageSupported(string $lang): bool | |||
| return \in_array($lang, $supportedLanguages, true); | |||
| } | |||
|
|
|||
| private function getLines(string $code): array | |||
There was a problem hiding this comment.
was not used anywhere
alamirault
approved these changes
Dec 29, 2022
|
Very nice fix! Thanks Nicolas. |
|
Thank you @nikophil. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
here is a fix for symfony/symfony-docs#17587
I had hard time understanding the problem was only occurring for code of type "text"!
cheers!