Skip to content

Process sidebar directive's titles as span nodes #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Process sidebar directive's titles as span nodes #125

merged 1 commit into from
Oct 22, 2021

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented Oct 21, 2021

Fixes #115

I've also added composer.lock to the gitignore, not sure why it wasn't in there already.

@wouterj wouterj mentioned this pull request Oct 21, 2021
Closed
@javiereguiluz javiereguiluz force-pushed the issue-115/sidebar-titles branch from 459d2a1 to 3d7d07a Compare October 22, 2021 10:32
@javiereguiluz javiereguiluz added the enhancement New feature or request label Oct 22, 2021
@javiereguiluz
Copy link
Collaborator

Thanks Wouter.

@javiereguiluz javiereguiluz merged commit ea6cedd into symfony-tools:main Oct 22, 2021
@wouterj wouterj deleted the issue-115/sidebar-titles branch October 22, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar titles can contain other RST elements
3 participants
@wouterj @javiereguiluz @weaverryan