Add the screencast admonition #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
Oct 13, 2021
…iereguiluz, weaverryan) This PR was merged into the main branch. Discussion ---------- Add support for an alternative screencast directive In #119 we added the `.. screencast::` directive, but Symfony Docs still use the old `.. admonition:: Screencast` syntax. We cannot update Symfony Docs yet, so we need to support both. I thought that the simple code of this PR would be enough, but it's not working. Anyone knows why? Thanks! Commits ------- add05d8 Fixing test to not rely on screencast style admonition 18dd3dc Fixing initialization or Parser in test f080e8b Add support for an alternative screencast directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.