[Themes] Upgrade to rtd 1.0.0rc1 and override incompatible default changes #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
changed the title
|
@weaverryan @Nyholm is it possible to get this PR merged and tagged with a version? This only changes the "rtd" theme, which shouldn't affect symfony.com build pipelines. |
Nyholm
approved these changes
Aug 28, 2021
|
Thanks Wouter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version is a bit nicer imho :) (especially with definition lists)
We also changed some templates in the
defaulttheme for the symfony.com styling, but this broke the rtd theme. I've added the original templates to the rtd theme in order to fix our CI builds. I've also recommended using this tool to check transitions to reStructuredText for some bundle authors, so not seeing headlines and code examples is a bit of a shock for them.