Skip to content

Minor issue when highlighting some PHP attributes #174

Closed
@javiereguiluz

Description

@javiereguiluz

The PHP attribute highlight feature that @wouterj implemented in #173 works really well. However, I found an edge case. See:

https://symfony.com/doc/current/reference/constraints/AtLeastOneOf.html#basic-usage

The <span> is applied to the entire PHP attribute, so everything is highlighted as an attribute in this case even if statements like new Assert\Regex('/#/') should be highlighted differently.

In any case, this is very rarely used in Symfony Docs, so it's fine to keep this edge case unfixed if the possible solution is very complex or breaks other things. Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions