Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Updated the way fixtures should be loaded #818

Merged
merged 3 commits into from
Apr 1, 2017
Merged

Conversation

bogdaniel
Copy link
Contributor

While i was following the tutorial i noticed that when i was running php bin\console doctrine:phpcr:fixtures:load it hit me with errors. The only way i managed loading the fixtures was by using --append ( found the solution somewhere on google groups )

While i was following the tutorial i noticed that when i was running php bin\console doctrine:phpcr:fixtures:load it hit me with errors. The only way i managed loading the fixtures was by using --append ( found the solution somewhere on google groups )
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. seems we changed things a while ago and did not notice that this breaks the flow.

@@ -198,7 +198,7 @@ Now empty your repository, reinitialize it and reload your fixtures:

.. code-block:: bash

$ php bin/console doctrine:phpcr:fixtures:load
$ php bin/console doctrine:phpcr:fixtures:load --append
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to have been broken in 775d2ec - the text above this block even still talks about emptying the repository and reinitialize.

i think instead of appending, we should add these two commands back in (above this line):

$ php bin/console doctrine:phpcr:node:remove /cms
$ php bin/console doctrine:phpcr:repository:init

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this would be even a better fix to the issue. :-)

Based on suggestions i modified the request.
@@ -197,7 +197,8 @@ Now:
Now empty your repository, reinitialize it and reload your fixtures:

.. code-block:: bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to keep a blank line, otherwise the .rst parser falls flat on this.

@dbu dbu merged commit 23396a8 into symfony-cmf:master Apr 1, 2017
@dbu
Copy link
Member

dbu commented Apr 1, 2017

thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants