This repository was archived by the owner on Sep 16, 2021. It is now read-only.
[routing] change doc to best practices #801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Jan 25, 2017
| @@ -125,7 +125,7 @@ generic_controller | |||
|
|
|||
| The controller to use when the route enhancers only determined the template but | |||
| no explicit controller. The value is the name of a controller using either the | |||
| ``AcmeDemoBundle::Page::index`` or ``acme_demo.controller.page:indexAction`` | |||
| ``AppBundle::Page::index`` or ``app.page_controller:indexAction`` | |||
| notation. | |||
There was a problem hiding this comment.
Well, actually, all controller formats are supported right? So maybe we shouldn't explicitely mention these 2 (as you can also do FQCN::methodName)
| cmf_routing: | ||
| dynamic: | ||
| controllers_by_type: | ||
| editable: acme_main.controller:editableAction | ||
| editable: app.cms_controller:editableAction |
There was a problem hiding this comment.
As best practices don't suggest using controllers as services, what about using AppBundle:Cms:editable here?
| <?xml version="1.0" encoding="UTF-8" ?> | ||
| <!-- app/config/config.xml --> |
| @@ -211,6 +214,7 @@ choose this controller to handle the request. | |||
| .. code-block:: xml | |||
|
|
|||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <!-- app/config/config.xml --> | |||
| @@ -264,7 +272,7 @@ setting is set as controller. | |||
|
|
|||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <container xmlns="http://symfony.com/schema/dic/services"> | |||
|
|
|||
| <!-- app/config/config.xml --> | |||
| @@ -61,6 +62,7 @@ is executed. | |||
| .. code-block:: xml | |||
|
|
|||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <!-- app/config/services.xml --> | |||
There was a problem hiding this comment.
... and here (you get the point, everywhere 😉 )
|
incorporated all this feedback in #804 that is against the correct branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.