-
Notifications
You must be signed in to change notification settings - Fork 156
add unmaintained notice to the bundles that are no longer maintained #793
Conversation
once this is merged, i will also adjust the README of those repositories. should we mark them as abandoned on packagist, or is that going too far? |
49d49c0
to
676d820
Compare
Is it possible to de-abandon packages? If yes, I suggest marking them as abandoned. |
ok, we established its possible to revert abandoning on packagist. i will mark them as abandoned when we merge this. and also update the readme, similar to blog-bundle |
okay to merge or anything missing / to correct? |
|
||
This bundle might have outdated documentation and there is no support and | ||
bugs will usually not be fixed. We will still try to review bug fix pull | ||
requests and merge them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I commented on this one, but seems like it's missing now. I would reorder this a bit:
To focus our efforts onto a manageable number of packages, this package is currently not maintained. Security fixes and submitted bug fixes will still be released, but no new features should be expected.
If you want to help co-maintaining this package, tell us in a GitHub issue or in
#symfony_cmf
of [Symfony slack](http://slackinvite url thing)
676d820
to
9f586ea
Compare
or in #symfony_cmf of the `Symfony devs slack`_. | ||
|
||
This bundle might have outdated documentation and there is no support and | ||
bugs will usually not be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the disclaimer. i kept this sentence because i want to make it really clear that there is not just a feature freeze but no effort put into the unmaintained bundles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, let's add this sentence to the first paragraph. Currently it's "Note about unmaintained -> You can help! -> Another note about maintained", which is a bit weird structure imo
9f586ea
to
7a4b906
Compare
agreed, made that note more logically structured |
👍 |
fix #792
i remember proposing to also unmaintain the block bundle, but that did not get consensous...