Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

add unmaintained notice to the bundles that are no longer maintained #793

Merged
merged 1 commit into from
Jan 27, 2017

Conversation

dbu
Copy link
Member

@dbu dbu commented Jan 22, 2017

fix #792

  • do you agree with the wording?
  • did i pick the right bundles, or is there others i missed / some that we consider still maintained? note that https://github.com/symfony-cmf/blog-bundle is not mentioned at all in the cmf docs, so imo we don't need to start mentioning it.

i remember proposing to also unmaintain the block bundle, but that did not get consensous...

@dbu dbu added the wip/poc label Jan 22, 2017
@dbu
Copy link
Member Author

dbu commented Jan 22, 2017

once this is merged, i will also adjust the README of those repositories. should we mark them as abandoned on packagist, or is that going too far?

@dbu dbu force-pushed the add-unmaintained-notice branch from 49d49c0 to 676d820 Compare January 22, 2017 12:10
@wouterj
Copy link
Member

wouterj commented Jan 22, 2017

should we mark them as abandoned on packagist, or is that going too far?

Is it possible to de-abandon packages? If yes, I suggest marking them as abandoned.

@dbu
Copy link
Member Author

dbu commented Jan 22, 2017

ok, we established its possible to revert abandoning on packagist. i will mark them as abandoned when we merge this. and also update the readme, similar to blog-bundle

@dbu
Copy link
Member Author

dbu commented Jan 23, 2017

okay to merge or anything missing / to correct?


This bundle might have outdated documentation and there is no support and
bugs will usually not be fixed. We will still try to review bug fix pull
requests and merge them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I commented on this one, but seems like it's missing now. I would reorder this a bit:

To focus our efforts onto a manageable number of packages, this package is currently not maintained. Security fixes and submitted bug fixes will still be released, but no new features should be expected.

If you want to help co-maintaining this package, tell us in a GitHub issue or in #symfony_cmf of [Symfony slack](http://slackinvite url thing)

@dbu dbu force-pushed the add-unmaintained-notice branch from 676d820 to 9f586ea Compare January 24, 2017 09:34
or in #symfony_cmf of the `Symfony devs slack`_.

This bundle might have outdated documentation and there is no support and
bugs will usually not be fixed.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the disclaimer. i kept this sentence because i want to make it really clear that there is not just a feature freeze but no effort put into the unmaintained bundles.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, let's add this sentence to the first paragraph. Currently it's "Note about unmaintained -> You can help! -> Another note about maintained", which is a bit weird structure imo

@dbu dbu force-pushed the add-unmaintained-notice branch from 9f586ea to 7a4b906 Compare January 26, 2017 08:55
@dbu
Copy link
Member Author

dbu commented Jan 26, 2017

agreed, made that note more logically structured

@wouterj
Copy link
Member

wouterj commented Jan 27, 2017

👍

@dbu dbu merged commit aeab7bd into 2.0 Jan 27, 2017
@dbu dbu removed the wip/poc label Jan 27, 2017
@wouterj wouterj deleted the add-unmaintained-notice branch January 27, 2017 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants