This repository was archived by the owner on Sep 16, 2021. It is now read-only.
better explain the form type #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -240,14 +240,29 @@ the ``SeoMetadata`` entity. | |||
| Form Type | |||
| --------- | |||
|
|
|||
| The bundle also provides a special form type called ``seo_metadata``. This | |||
| form type can be used in forms to edit the ``SeoMetadata`` object. | |||
| The bundle also provides a special form type called ``Symfony\Cmf\Bundle\SeoBundle\Form\Type\SeoMetadataType`` | |||
There was a problem hiding this comment.
we should probably hunt through all of the documentation for these... but not in this PR
|
@wouterj do you have an idea what the sphinx error is about? api_url indeed is assigned a string, so what is wrong? did they introduce api_url as a system variable and we somehow clash with that now? |
|
|
||
| /** @var FormMapper $formMapper */ | ||
| $formMapper | ||
| ->add('seoMetadata', 'Symfony\Cmf\Bundle\SeoBundle\Form\Type\SeoMetadataType') |
There was a problem hiding this comment.
In the core docs, we decided to use SeoMetadataType::class + a use statement.
There was a problem hiding this comment.
indeed much more elegant. but that is PHP 5.5 + only. is that ok?
|
rebased to get the sphinx build fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some documentation to go with symfony-cmf/seo-bundle#277