Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

seo corrections #575

Merged
merged 4 commits into from
Sep 24, 2014
Merged

seo corrections #575

merged 4 commits into from
Sep 24, 2014

Conversation

cordoval
Copy link
Contributor

Q A
Bug Fix? n
New Feature? n
BC Breaks? n
Deprecations? n
Tests Pass? n
Fixed Tickets symfony-cmf/seo-bundle#146
License MIT
Doc PR

Sent using Gush

@cordoval cordoval changed the title [WIP] seo corrections seo corrections Sep 24, 2014
@cordoval
Copy link
Contributor Author

@ElectricMaxxx @wouterj ship it boss 👍

@@ -30,6 +30,9 @@ the ``SeoMetadata``::
}
}

If you are using PHP5.4+ you may also benefit from using the trait ``SeoAwareTrait``
to plug these behavior into your model.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put this into a tip directive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it .. tip:: ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
Op 24 sep. 2014 08:30 schreef "Luis Cordova" notifications@github.com:

In bundles/seo/seo_aware.rst:

@@ -30,6 +30,9 @@ the SeoMetadata::
}
}

+If you are using PHP5.4+ you may also benefit from using the trait SeoAwareTrait
+to plug these behavior into your model.

is it .. tip:: ?


Reply to this email directly or view it on GitHub
https://github.com/symfony-cmf/symfony-cmf-docs/pull/575/files#r17955772
.

@cordoval
Copy link
Contributor Author

👍 @wouterj

wouterj added a commit that referenced this pull request Sep 24, 2014
@wouterj wouterj merged commit 8420e5b into symfony-cmf:dev Sep 24, 2014
@wouterj wouterj mentioned this pull request Sep 24, 2014
@wouterj
Copy link
Member

wouterj commented Sep 24, 2014

Merged it into the correct branch now... Thanks @cordoval for your corrections, great to have people fixing the docs!

wouterj added a commit that referenced this pull request Sep 24, 2014
This PR was submitted for the dev branch but it was merged into the master branch instead (closes #575).

Discussion
----------

seo corrections

|Q            |A                                                  |
|---          |---                                                |
|Bug Fix?     |n                                                  |
|New Feature? |n                                                  |
|BC Breaks?   |n                                                  |
|Deprecations?|n                                                  |
|Tests Pass?  |n                                                  |
|Fixed Tickets|https://github.com/symfony-cmf/SeoBundle/issues/146|
|License      |MIT                                                |
|Doc PR       |                                                   |

Commits
-------

b917a73 seo corrections
f0d455e Fixed filename in comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants