Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Various fixes for tutorial #562

Closed
wants to merge 1 commit into from
Closed

Various fixes for tutorial #562

wants to merge 1 commit into from

Conversation

dantleech
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all (or 2.3+)
Fixed tickets #559

@@ -108,7 +108,7 @@ object and all the ``Posts`` to the view::
*/
public function pageAction($contentDocument)
{
$dm = $this->get('doctrine_phpcr')->getManagerForClass('AcmeBasicCmsBundle:Post');
$dm = $this->get('doctrine_phpcr')->getManager();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just surplass to requirements..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean it makes things needlessly complex?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@lsmith77
Copy link
Member

lsmith77 commented Sep 1, 2014

I guess this could have all gone to 1.1, aka master, as well?


.. code-block:: yaml

Acme\BasicCmsBundle\Document\Site:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the full config example, is it? It confused me :)

You also need XML and PHP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I know :) I was in a hurry this morning and just wanted to get this up.

@lsmith77
Copy link
Member

lsmith77 commented Sep 7, 2014

FYI #564

@wouterj
Copy link
Member

wouterj commented Sep 8, 2014

ping @dantleech

@dantleech
Copy link
Member Author

Updated.

@wouterj
Copy link
Member

wouterj commented Oct 14, 2014

Thanks @dantleech.

@wouterj wouterj closed this in c69d7fa Oct 14, 2014
@wouterj wouterj deleted the tutorial_fixes branch October 14, 2014 20:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants