Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Seo bundle documentation #438

Closed

Conversation

ElectricMaxxx
Copy link
Member

So now it should work. I just compare with dev.

}

A very basic use case
_____________________
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have no clue why that headlines size are jumping from big to small

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cmf doc contains guidelines which headlines to use for what level. afaik underline is never used

@ElectricMaxxx
Copy link
Member Author

Nice that the error occurs in my PR

@ElectricMaxxx
Copy link
Member Author

For that and the design of the navigation i would need some help:

/home/travis/build/symfony-cmf/symfony-cmf-docs/bundles/seo/index.rst:: WARNING: document isn't included in any toctree

@wouterj
Copy link
Member

wouterj commented Apr 3, 2014

You have to put seo/index in the toctree in bundles/index.rst

@@ -0,0 +1,7 @@
SeoBundle
=============
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tagline (line containing = characters) should be as long as the headline itself. There are more occurences in this PR which needs a fix

@wouterj
Copy link
Member

wouterj commented Apr 3, 2014

Can you please update your line breaks in the PR, so there is a line break after the first word that crosses the 72th character. The very low width you've used now doesn't make it easy to review

@ElectricMaxxx
Copy link
Member Author

I have chosen a with? I just put some chars in that file, but can't remember to set a with.

@ElectricMaxxx
Copy link
Member Author

I have no clue how these references work for rst files. Just copied the files.

@ElectricMaxxx
Copy link
Member Author

Ah but now i understand it on second view.

Both take care on search engines, which does not like
it to have same content under different routes.

The SeoBundle uses sonatas SeoBundle and its TwigHelper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMF SeoBundle uses the SonataSeoBundle and ...

@wouterj wouterj added this to the 1.1 milestone Apr 6, 2014
@wouterj wouterj mentioned this pull request Apr 6, 2014
2 tasks
@wouterj
Copy link
Member

wouterj commented Apr 6, 2014

continues in #442

@wouterj wouterj closed this Apr 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants