Add a cookbook entry about url trailing slash redirect #323
Conversation
| Redirect URLs with a trailing slash | ||
| =================================== | ||
|
|
||
| .. include:: _outdate-caution.rst.inc |
There was a problem hiding this comment.
I don't think this is outdated, is it?
|
I'm updating the PR. But I finally have an issue with the action, it does not work as expected. I'm trying to find out why. |
|
Thanks for your feedback. I've juste pushed the updates. The problem I had was caused by the JMSI18nRoutingBundle. I had to add the |
|
All lines should be wrapped at the 72th character. |
I think it's an edge case. Unless we get a lot of reports from people having this problem I prefer to not document it. |
|
Could you please add the PR template to your PR description? |
|
Done ! |
|
|
||
| .. note:: | ||
|
|
||
| For the moment, the :doc:`RoutingBundle <../bundles/routing/introduction>` can't achieve this automatically. |
There was a problem hiding this comment.
sorry, you forgot to wrap this line :)
There was a problem hiding this comment.
Ahah ! Should I wrap it before the :doc: ?
|
It should be ok ;) |
Add a cookbook entry about url trailing slash redirect
|
🍻 Thanks ! |
|
Thank you for creating the first tips & tricks article for the CMF! I've done some minor changes in c66b030 , mainly to move it to a section. |
|
You're welcome, thank you for your help ! |
|
@EmmanuelVella I thought a bit about this, and maybe it's better to move it to the core docs, as it's not a cmf specific article and it's a common problem. You can just copy the file to the symfony docs (remove the note about the RoutingBundle), update their toctrees and request a PR. Then also request a PR here which removes the article and it's references. I'll keep an eye on both PRs and merge it when to other is merged too. |
|
oh, indeed. searching for "symfony2 trailing slash" in google brings forth a ton of stack overflow and other places where people ask for this and sometimes get ok answers, sometimes bad ones. (i.e. leading to serve the same content under multiple URLs which is a no-no if you want google to like you). so moving this to symfony core doc sounds like a valid idea. |
|
Hi, I just submitted a PR in the symfony cookbook. I will submit another PR here to remove the cookbook entry when the first one will be merged ! |
|
just already submit the PR here. I'll merge it when the upstream PR is merged too. |
|
Ok, let me just do it then I submit it. |
|
Done ! |
|
thank you! |
Discussed in this mailing list topic : https://groups.google.com/forum/#!topic/symfony-cmf-devs/USBi-njDmk4