Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

minor tweaks to the routing book chapter #288

Merged
merged 1 commit into from
Oct 5, 2013
Merged

minor tweaks to the routing book chapter #288

merged 1 commit into from
Oct 5, 2013

Conversation

lsmith77
Copy link
Member

@lsmith77 lsmith77 commented Oct 4, 2013

No description provided.

@@ -84,6 +79,96 @@ will look like this

See also official Symfony2 `documentation for DependencyInjection tags`_

Integrating with SonataAdmin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i moved this here from the book, since i felt this was a bit too detailed for the book. however these should then maybe become sections with their own files .. rather than be put into the introduction.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most admin sections are short and should not be put in a seperate article, but this one is long enough. So if the intro is getting too long, let's move this one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for having it here rather than in the book. however, it should go into the dynamic.rst file as there we explain the dynamic router in detail. we said elsewhere to put sonata admin into the main doc and not its own file as long as its just a short section. it is not too long imo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont quite understand what you are saying here @dbu .. why should the sonata stuff be placed in dynamic.rst?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's only the admin for stuff in the dynamic router.

@lsmith77
Copy link
Member Author

lsmith77 commented Oct 5, 2013

ready to merge?

dbu added a commit that referenced this pull request Oct 5, 2013
minor tweaks to the routing book chapter
@dbu dbu merged commit 7ba6c1b into master Oct 5, 2013
@dbu dbu deleted the routing branch October 5, 2013 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants