Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Improved PWF doc #278

Merged
merged 4 commits into from
Oct 1, 2013
Merged

Improved PWF doc #278

merged 4 commits into from
Oct 1, 2013

Conversation

dantleech
Copy link
Member

Added a section explaining how to implement PWF interfaces and a section showing the PWF workflow with diagrams.

.idea/
.autosave
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1, on both lines. These should be put in a local .git/info/exclude or git update-index --assume-unchanged files imo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what .idea/ is, but I think .dia makes sense as I have included the source files for the diagrams, so I would assume people would use Dia to edit them, and they would probably end up accidentally adding the autosave files as I did.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.idea is phpstorm and friends. but indeed that should go into the users local config. the same holds for .dia. this is about tools an editor is using that pollute folders with their metadata - the project should not need to know about it.

lets remove both lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dantleech
Copy link
Member Author

ok, hows that?


Below is an example publish workflow implementation::

<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never use PHP open tags in PHP examples

@dantleech
Copy link
Member Author

Updated.

@wouterj
Copy link
Member

wouterj commented Sep 30, 2013

+1 for merging when ready

@dantleech
Copy link
Member Author

Good for me.

dbu added a commit that referenced this pull request Oct 1, 2013
@dbu dbu merged commit 576a99b into master Oct 1, 2013
@dbu dbu deleted the core_pwf branch October 1, 2013 06:48
@dbu
Copy link
Member

dbu commented Oct 1, 2013

thanks dan and wouter!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants