-
Notifications
You must be signed in to change notification settings - Fork 156
Improved PWF doc #278
Improved PWF doc #278
Conversation
.idea/ | ||
.autosave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1, on both lines. These should be put in a local .git/info/exclude
or git update-index --assume-unchanged
files imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what .idea/ is, but I think .dia makes sense as I have included the source files for the diagrams, so I would assume people would use Dia to edit them, and they would probably end up accidentally adding the autosave files as I did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.idea is phpstorm and friends. but indeed that should go into the users local config. the same holds for .dia. this is about tools an editor is using that pollute folders with their metadata - the project should not need to know about it.
lets remove both lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
ok, hows that? |
|
||
Below is an example publish workflow implementation:: | ||
|
||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never use PHP open tags in PHP examples
Updated. |
+1 for merging when ready |
Good for me. |
thanks dan and wouter! |
Added a section explaining how to implement PWF interfaces and a section showing the PWF workflow with diagrams.