Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

restructured CoreBundle docs #270

Merged
merged 2 commits into from
Sep 28, 2013
Merged

restructured CoreBundle docs #270

merged 2 commits into from
Sep 28, 2013

Conversation

lsmith77
Copy link
Member

Q A
Doc fix? yes
New docs? yes
Applies to all
Fixed tickets part of #262

@@ -0,0 +1,49 @@
Dependency Injection Tags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an index directive:

.. index::
    single: Dependency Injection Tags; CoreBundle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@wouterj
Copy link
Member

wouterj commented Sep 28, 2013

Great job!


Enabling this setting will also automatically enable the equivalent setting in the following Bundles:

* :doc:`BlockBundle <../../bundles/block>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bundles/block/introduction


.. _config-core-persistence:

persistence
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we talk about the core bundle prepending that configuration to the other cmf bundles? here or in the bundle documentation somewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is documented in the persistence.phpcr.enabled section

dbu added a commit that referenced this pull request Sep 28, 2013
@dbu dbu merged commit 454893b into master Sep 28, 2013
@dbu dbu deleted the core-bundle branch September 28, 2013 21:15
@lsmith77
Copy link
Member Author

seems like i screwed something up here. CoreBundle isn't listed on the main CMF doc page and http://symfony.com/doc/master/cmf/bundles/core/index.html also does not work

@wouterj
Copy link
Member

wouterj commented Sep 28, 2013

That looks pretty strange, no build errors and I cannot find the problem too

@wouterj
Copy link
Member

wouterj commented Sep 29, 2013

Well, there are a lot of build errors. Pretty strange:

en/2.2/cmf/bundles/index.rst:4: WARNING: toctree contains reference to nonexisting document u'cmf/bundles/core/index'
en/2.2/cmf/index.rst:94: WARNING: toctree contains reference to nonexisting document u'cmf/bundles/core/index'
en/2.2/cmf/bundles/block/types.rst:22: WARNING: undefined label: bundle-core-publish_workflow (if the link has no caption the label must precede a section header)
en/2.2/cmf/bundles/map.rst.inc:19: WARNING: unknown document: core/introduction
en/2.2/cmf/bundles/map.rst.inc:20: WARNING: unknown document: core/publish_workflow
en/2.2/cmf/bundles/map.rst.inc:21: WARNING: unknown document: core/dependency_injection_tags
en/2.2/cmf/bundles/map.rst.inc:22: WARNING: unknown document: core/templating
en/2.2/cmf/bundles/map.rst.inc:23: WARNING: unknown document: core/multilang
en/2.2/cmf/bundles/menu.rst:391: WARNING: undefined label: bundle-core-publish_workflow (if the link has no caption the label must precede a section header)
en/2.2/cmf/reference/configuration/routing.rst:224: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/routing.rst:234: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/routing.rst:244: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/routing.rst:254: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/routing.rst:266: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/routing.rst:362: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/simple_cms.rst:86: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/simple_cms.rst:137: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/simple_cms.rst:145: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/simple_cms.rst:156: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/simple_cms.rst:175: WARNING: unknown document: ../../bundles/core/index
en/2.2/cmf/reference/configuration/simple_cms.rst:341: WARNING: unknown document: ../../bundles/core/index

@wouterj
Copy link
Member

wouterj commented Sep 29, 2013

Our build is still passing.. Can it be a bug on symfony.com, @fabpot?

@lsmith77
Copy link
Member Author

i found one typo that I fixed, maybe that does the trick:
739299b

@lsmith77
Copy link
Member Author

this has not improved anything .. then again I have a feeling that no new build has run. is there any place where i can see the time of the last build?

@lsmith77
Copy link
Member Author

would be great to have that time on http://symfony.com/doc/build_errors

@dbu
Copy link
Member

dbu commented Sep 30, 2013

building locally does not throw errors and the cure bundle does show up

@wouterj
Copy link
Member

wouterj commented Sep 30, 2013

@lsmith77 the docs are rendered quite fast, the build errors page is rendered once at French night (2.30 AM if I'm not mistaken)

And indeed, everything works smoothly locally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants