Improve development script #1902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
Oct 4, 2020
| brew install cmake ninja llvm sccache wasmer | ||
| if [[ ! -z "$CI" ]]; then | ||
| brew uninstall $(brew list | grep python@2) | ||
| brew install cmake ninja llvm sccache wasmer |
There was a problem hiding this comment.
I'd move this line outside of the if block to allow people who don't have these dependencies installed to build locally. If they do have those installed, this line won't have any destructive effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always use this custom build-preset to build on local machine because we don't need to build other packages like SwiftPM or Foundation when debugging compiler. This PR separate build-presets into "build" and "install" presets.
When developing compiler and want to build only the target compiler, you can build with the below command.
$ ./utils/build-script --preset=webassembly-macos-target --preset-file ../build-presets.ini \ SOURCE_PATH=$(dirname $(pwd)) \ TOOLS_BIN_DIR=/usr/local/opt/llvm/bin \ C_CXX_LAUNCHER=$(which sccache)I'll update how to build section in swiftwasm-book.