Skip to content

Simplify build system #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@ on: [push, pull_request]
jobs:
test:
name: Build and Test
runs-on: macOS-10.15
strategy:
matrix:
os: [macOS-10.15]
include:
- os: macOS-10.15
toolchain: https://github.com/swiftwasm/swift/releases/download/swift-wasm-DEVELOPMENT-SNAPSHOT-2020-03-08-a/swift-wasm-DEVELOPMENT-SNAPSHOT-2020-03-08-a-osx.tar.gz
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@master
Expand All @@ -19,4 +25,4 @@ jobs:
make bootstrap
make test
env:
TOOLCHAIN_DOWNLOAD: https://github.com/kateinoigakukun/swiftwasm/releases/download/swift-wasm-DEVELOPMENT-SNAPSHOT-2020-03-05-a/swift-wasm-DEVELOPMENT-SNAPSHOT-2020-03-05-a-osx.tar.gz
TOOLCHAIN_DOWNLOAD: ${{ matrix.toolchain }}
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
dist
node_modules
.wasi-sdk
.DS_Store
/.build
/Packages
Expand Down
2 changes: 1 addition & 1 deletion .swift-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
wasm-DEVELOPMENT-SNAPSHOT-2020-03-05-a
wasm-DEVELOPMENT-SNAPSHOT-2020-03-08-a
8 changes: 0 additions & 8 deletions Example/JavaScriptKitExample/Makefile

This file was deleted.

3 changes: 2 additions & 1 deletion Example/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ MAKEFILE_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

.PHONY: JavaScriptKitExample
JavaScriptKitExample:
cd JavaScriptKitExample && make build
cd JavaScriptKitExample && \
swift build --triple wasm32-unknown-wasi

dist/JavaScriptKitExample.wasm: JavaScriptKitExample
mkdir -p dist
Expand Down
8 changes: 0 additions & 8 deletions IntegrationTests/JavaScriptKitExec/Makefile

This file was deleted.

3 changes: 2 additions & 1 deletion IntegrationTests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ MAKEFILE_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

.PHONY: JavaScriptKitExec
JavaScriptKitExec:
cd JavaScriptKitExec && make build
cd JavaScriptKitExec && \
swift build --triple wasm32-unknown-wasi

dist/JavaScriptKitExec.wasm: JavaScriptKitExec
mkdir -p dist
Expand Down
11 changes: 3 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
MAKEFILE_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
WASI_SDK_DIR ?= $(MAKEFILE_DIR)/.wasi-sdk
WASI_SYSROOT ?= $(WASI_SDK_DIR)/share/wasi-sysroot

.PHONY: bootstrap
bootstrap:
cd Runtime && npm install

.PHONY: build
build: .wasi-sdk/dummy
./script/build-package.sh $(WASI_SYSROOT)
build:
swift build --triple wasm32-unknown-wasi
cd Runtime && npm run build

.PHONY: test
test: build
test:
cd IntegrationTests && make test

.wasi-sdk/dummy:
./script/install-wasi-sdk.sh $(WASI_SDK_DIR)
touch .wasi-sdk/dummy
18 changes: 16 additions & 2 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,23 @@ let package = Package(
targets: [
.target(
name: "JavaScriptKit",
dependencies: ["_CJavaScriptKit"]),
dependencies: ["_CJavaScriptKit"],
linkerSettings: [
.unsafeFlags([
"-Xlinker",
"--export=swjs_call_host_function",
"-Xlinker",
"--export=swjs_prepare_host_function_call"
])
]),
.target(
name: "_CJavaScriptKit"),
name: "_CJavaScriptKit",
linkerSettings: [
.unsafeFlags([
"-Xlinker",
"--allow-undefined",
])
]),
.testTarget(
name: "JavaScriptKitTests",
dependencies: ["JavaScriptKit"]),
Expand Down
10 changes: 0 additions & 10 deletions script/build-package.sh

This file was deleted.

17 changes: 0 additions & 17 deletions script/install-wasi-sdk.sh

This file was deleted.