Add temporary shims to Bug's Codable implementation to support proposed new layout.
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oposed new layout. We're proposing a new set of stored properties for `Bug` in #412. This new layout is incompatible with the old one when using `Codable`. This change adds a (very!) temporary workaround to ensure that bugs encoded with the current layout can be decoded with the new one once it is accepted and merged in.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
dennisweissmann
approved these changes
May 16, 2024
|
@swift-ci please test |
stmontgomery
approved these changes
May 16, 2024
|
Windows failure is a known issue. Linux CI is down right now. Merging as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're proposing a new set of stored properties for
Bugin #412. This new layout is incompatible with the old one when usingCodable. This change adds a (very!) temporary workaround to ensure that bugs encoded with the current layout can be decoded with the new one once it is accepted and merged in.This implementation can be removed when #412 is merged.
Checklist: