Refine makeTestFilter() further.
#154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refines the previous PR for this issue, #153. It removes the internal overload of `makeTestFilter(matching:uncheckedTestFilter:)` because it is redundant: since the result needs to be passed to `uncheckedTestFilter` to preserve its lack of `isHidden`-checking, it doesn't _also_ need to impose its own check. I did add an internal overload of `makeTestFilter()` to the test target that just returns `selection.contains` as a convenience. Resolves rdar://119205417 (again.)
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
stmontgomery
reviewed
Dec 5, 2023
stmontgomery
approved these changes
Dec 5, 2023
suzannaratcliff
approved these changes
Dec 5, 2023
|
@swift-ci please test |
stmontgomery
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the previous PR for this issue, #153. It removes the internal overload of
makeTestFilter(matching:uncheckedTestFilter:)because it is redundant: since the result needs to be passed touncheckedTestFilterto preserve its lack ofisHidden-checking, it doesn't also need to impose its own check.I did add an internal overload of
makeTestFilter()to the test target that just returnsselection.containsas a convenience.Resolves rdar://119205417 (again.)
Checklist: