Don’t remove #if attributes with AttributeRemover
#2945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes swiftlang#2923 rdar://141840779
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
rintaro
reviewed
Jan 27, 2025
| for case .attribute(let attribute) in node { | ||
| for attribute in node { | ||
| guard case .attribute(let attribute) = attribute else { | ||
| filteredAttributes.append(attribute) |
There was a problem hiding this comment.
What if #if ... #endif contained attributes matching self.predicate(attribute)? Or it never happens because MacroSystem doesn't support #if attributes?
There was a problem hiding this comment.
My thought is that MacroSystem doesn’t know how to evaluate #if conditions, so just keeping them verbatim is the best we can do…
There was a problem hiding this comment.
I see MacroApplication.macroAttributes(attachedTo:) doesn't look into #if at all at this point. So yeah, this is fine.
rintaro
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2923
rdar://141840779