Skip to content

[Syntax] Let SyntaxIdentifier use RawSyntax.ID directly #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2025
Merged

[Syntax] Let SyntaxIdentifier use RawSyntax.ID directly #2938

merged 1 commit into from
Jan 11, 2025
+4 −11

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jan 10, 2025

There was no reason to convert it to UInt.

@rintaro
[Syntax] Let SyntaxIdentifier use RawSyntax.ID directly
3883e3c 
There was no reason to convert it to UInt.
@rintaro
Copy link
Member Author

rintaro commented Jan 10, 2025

@swift-ci Please test

@rintaro rintaro merged commit 00f5b14 into swiftlang:main Jan 11, 2025
3 checks passed
@rintaro rintaro deleted the syntaxidentifier-root-id branch January 21, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @ahoppen