Skip to content

[bazel] Update Bazel README with Bzlmod & WORKSPACE examples #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

ssarad
Copy link
Contributor

@ssarad ssarad commented Dec 15, 2024

Add an example of how to pull swift-syntax with bzlmod and WORKSPACE

@ssarad
Copy link
Contributor Author

ssarad commented Dec 15, 2024

@keith Can I have you take a look as well please?

@ssarad
Copy link
Contributor Author

ssarad commented Dec 15, 2024

@swift-ci please test

@ssarad ssarad changed the title Update Bazel README with Bzlmod examples, WORKSPACE deprecation warning [bazel] Update Bazel README with Bzlmod examples, WORKSPACE deprecation warning Dec 15, 2024
@dduan
Copy link
Contributor

dduan commented Dec 15, 2024

@swift-ci please test

@dduan dduan self-requested a review December 15, 2024 21:24
@ssarad ssarad changed the title [bazel] Update Bazel README with Bzlmod examples, WORKSPACE deprecation warning [bazel] Update Bazel README with Bzlmod & WORKSPACE examples Dec 15, 2024
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i doubt we'll keep these versions up to date so it's definitely useful to have the links out to the newer versions

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
@ssarad
Copy link
Contributor Author

ssarad commented Dec 15, 2024

Thanks for all the reviews! @keith @dduan , not sure why the CI tests aren't starting but anything left to merge this?

@keith
Copy link
Member

keith commented Dec 15, 2024

@swift-ci please test

@keith keith enabled auto-merge (squash) December 15, 2024 22:28
@ssarad
Copy link
Contributor Author

ssarad commented Dec 16, 2024

@swift-ci please test

@keith
Copy link
Member

keith commented Dec 16, 2024

@swift-ci please test windows platform

@keith keith merged commit 3a53f8f into swiftlang:main Dec 16, 2024
3 checks passed
@ssarad ssarad deleted the ssarad/update-bazel-readme branch December 16, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants