[cmake] Build version marker modules. #2616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The version marker modules are intentionally missing from the CMake build. The CMake build is primarily designed to be used when swift-syntax gets built to be linked into the compiler, which is always going to be in sync with the swift-syntax repository and thus doesn’t need them. What’s your motivation for adding the version marker modules to the CMake build? |
I'm building |
|
Is there any downside to including them? |
ahoppen
approved these changes
Apr 23, 2024
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the version marker modules to the CMake build, which were previously missing.
This replicates the behavior one gets when building w/SPM and allows consumers built with CMake to follow the
#if canImport(SwiftSyntax###)convention for versioning macros.