Skip to content

Added unit test for testing the removal of an attached macro #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SomeRandomiOSDev
Copy link
Contributor

Adds an additional unit test to test the removal of an attached attribute

@ahoppen
Copy link
Member

ahoppen commented Nov 15, 2023

Out of curiosity: What made you write this test case? Is there some kind of behavior you wanted to verify?

@SomeRandomiOSDev
Copy link
Contributor Author

Yeah, originally I developed this unit test to fix an issue that I had noticed here that had used a version of FixItApplier from a previous swift-syntax version, but since this type was refactored and made public it seems it would be good to have this in place to ensure that replacing nodes in this manner succeeds as expected.

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks for contributing the test case.

@ahoppen
Copy link
Member

ahoppen commented Nov 15, 2023

@swift-ci Please test

@kimdv
Copy link
Contributor

kimdv commented Nov 19, 2023

@swift-ci please test windows

@ahoppen
Copy link
Member

ahoppen commented Feb 5, 2024

Sorry for not merging this @SomeRandomiOSDev. I forgot about this. Closing this since @Matejkob has opened a PR that cherry-picks this and resolves the merge conflicts.

@ahoppen ahoppen closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants