[5.10] Cherry-pick a couple of macro system fixes for attached accessor macros #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an accessor macro returns an empty array, MacroSystem was failing with internal error messages because it tried ot parse an `AccessorBlockSyntax` from an empty string. To fix this, check if the expanded source is empty before trying to parse the `AccessorBlockSyntax`. (cherry picked from commit 46c02e9)
|
@swift-ci please test |
ahoppen
approved these changes
Nov 8, 2023
bnbarham
force-pushed
the
cherry-macro-system-fixes
branch
from
af44f0e to
6e2476e
Compare
|
@swift-ci please test |
(cherry picked from commit 9a2da83)
Postfix parsing should skip trailing closure if the base expression is a literal (which is not callable). (cherry picked from commit efbfbab)
SE-0389 specifies that a macro returning either a getter or setter should remove the initializer, if one exists. Resolves rdar://117442713 (swiftlang#2310) (cherry picked from commit b3a3f1f)
bnbarham
force-pushed
the
cherry-macro-system-fixes
branch
from
6e2476e to
418793a
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
ahoppen
added a commit
that referenced
this pull request
Nov 29, 2023
[5.10] Cherry-pick multiple PRs to `release/5.10` 🚥 #2339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2187 and #2315 into release/5.10.
MacroSystem- one to allow returning an empty list of accessors for an attached accessor macro and another to remove initializers if a getter/setter is returned.