Skip to content

[5.10][CMake] Remove 'SWIFT_SYNTAX_ALWAYS_SINGLE_THREADED' #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 4, 2023

Cherry-pick #2243 into release/5.10

  • Explanation: Using 'Darwin' overlay is not an issue anymore. Since we couldn't use Darwin in the compiler, we used to use Collection.elementsEqual(:_) instead of memcp which was slow. This should improve the performance of Swift parser.
  • Scope: Integrated SwiftParser
  • Risk: Low.
  • Issue: rdar://116542708
  • Reviewer: Ben Barham (@bnbarham)

Using 'Darwin' overlay is not an issue anymore.

(cherry picked from commit 2de0be5)
@rintaro rintaro requested a review from ahoppen as a code owner October 4, 2023 22:29
@rintaro
Copy link
Member Author

rintaro commented Oct 4, 2023

@swift-ci Please test

@rintaro rintaro changed the title [CMake] Remove 'SWIFT_SYNTAX_ALWAYS_SINGLE_THREADED' [5.10][CMake] Remove 'SWIFT_SYNTAX_ALWAYS_SINGLE_THREADED' Oct 4, 2023
@rintaro rintaro requested a review from bnbarham October 5, 2023 21:21
@rintaro rintaro merged commit dc426fa into swiftlang:release/5.10 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants