mark the BumpPtrAllocator class as @_spi(BumpPtrAllocator).

[ChiduAnush]

mark the BumpPtrAllocator class as @_spi(BumpPtrAllocator) instead of @_spi(RawSyntax).
resolves the issue #68351 (swiftlang/swift#68351)

[ahoppen]

Could you make sure that swift-syntax builds with this change? There are a couple of references to BumpPtrAllocator within the swift-syntax package that now no longer work. You will need to add @_spi(BumpPtrAllocator) to the imports in those files as well.

[ChiduAnush]

just to confirm, in the swift-syntax repo, inside the sources folder, inside the swiftSyntax folder, I need to include the @_spi(BumpPtrAllocator) in the required files?

which files exactly should I add this import statement?

when I do a search in vscode for BumpPtrAllocator, it returns about 16 results. most of then pass BumpPtrAllocator as StateAllocator

[bnbarham]

just to confirm, in the swift-syntax repo, inside the sources folder, inside the swiftSyntax folder, I need to include the @_spi(BumpPtrAllocator) in the required files?

If you run a build (either in your editor or just swift build) you'll see there will be many error: cannot find 'BumpPtrAllocator' in scope errors. They're caused because those files import SwiftSyntax with @_spi(RawSyntax) instead of BumpPtrAllocator as you've just changed it to.

You'll need to update those to use @_spi(BumpPtrAllocator), though It might be that they need both @_spi(RawSyntax) and @_spi(BumpPtrAllocator) depending on what's used - you'll need to check.

[ChiduAnush]

whenever I try running swift build in the cloned repo, I get the following error,
xcrun: error: unable to lookup item 'PlatformPath' from command line tools installation
xcrun: error: unable to lookup item 'PlatformPath' in SDK '/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk'

I have checked that xcode-select -p returns a valid path. so it is installed properly.

[ahoppen]

Oh, that's odd. I have never seen this issue before. A couple of questions:

• Which version of Xcode do you have installed.
• What's the output of xcode-select -p
• What's the output of swift --version?

[ChiduAnush]

okay, I got it. had to reinstall my Xcode.
worked fine. I saw the errors and put in the import statements wherever required.

[ChiduAnush]

I squashed the commits.

[AnthonyLatsis]

I think we prefer to pile up the attributes on a single import.

[ahoppen]

LGTM 👍🏽

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[ahoppen]

swiftlang/swift#68860

@swift-ci Please test