Teach TokenSpecSet about experimental features #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't say I love having to pass down experimental features to each TokenSpecSet, but I think it's ultimately better having them automatically handle experimental features instead of needing ad-hoc checks in the parser which, as demonstrated recently, can be error prone |
hamishknight
force-pushed
the
up-to-spec
branch
from
840a614 to
287717d
Compare
ahoppen
reviewed
Sep 18, 2023
Pass down the current set of experimental features to TokenSpecSets, and have generated TokenSpecSets automatically account for experimental features by returning `nil` if a given feature isn't active.
We now check these with the spec set.
hamishknight
force-pushed
the
up-to-spec
branch
from
287717d to
4695dc7
Compare
|
@swift-ci please test |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Sep 18, 2023
ahoppen
approved these changes
Sep 18, 2023
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass down the current set of experimental features to TokenSpecSets, and have generated TokenSpecSets automatically account for experimental features by returning
nilif a given feature isn't active. Should be NFC.