Disallow attaching peer macro to variable with multiple bindings in assertMacroExpansion
#2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
I'd prefer just banning it. It's effectively banned in the compiler at the moment anyway, we just need to improve the error message :) |
…assertMacroExpansion` The compiler currently invokes `expansion` twice with the exact same syntax node (rdar://114996981), which causes the same member to be generated twice, effectively disallowing the application of peer macro on variables with multiple bindings. Disallow them in `assertMacroExpansion` with a nice error message.
ahoppen
force-pushed
the
ahoppen/peer-on-var-with-multiple-bindings
branch
from
7c4a39e to
3ffa580
Compare
ahoppen
changed the title
assertMacroExpansion when applied to a variable declaration with multiple bindingsassertMacroExpansion
|
Updated the PR to ban peer macros on variables with multiple bindings in |
bnbarham
approved these changes
Sep 6, 2023
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler currently invokes
expansiontwice with the exact same syntax node (rdar://114996981), which causes the same member to be generated twice, effectively disallowing the application of peer macro on variables with multiple bindings. Disallow them inassertMacroExpansionwith a nice error message.