Skip to content

Make keyword precedence exhaustive #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2023
Merged

Make keyword precedence exhaustive #2151

merged 4 commits into from
Sep 8, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Sep 4, 2023

Fixes #2072

@kimdv kimdv requested a review from ahoppen as a code owner September 4, 2023 19:12
@kimdv kimdv force-pushed the kimdv/2072-make-the-switch-over-keywords-in-tokenprecedenceswift-exhaustive branch from 1faaae9 to 00103aa Compare September 4, 2023 19:28
@kimdv
Copy link
Contributor Author

kimdv commented Sep 4, 2023

Just a general question.
Are all keyword still used or are there leftovers from previous major Swift versions?

If yes, can some of those be removed?

ahoppen
ahoppen reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @kimdv. I have some opinions on the grouping and classification 😉

@kimdv kimdv force-pushed the kimdv/2072-make-the-switch-over-keywords-in-tokenprecedenceswift-exhaustive branch 4 times, most recently from c646b27 to 59d1c93 Compare September 7, 2023 18:46
@kimdv kimdv requested a review from ahoppen September 7, 2023 18:47
@kimdv kimdv force-pushed the kimdv/2072-make-the-switch-over-keywords-in-tokenprecedenceswift-exhaustive branch from 59d1c93 to c7977eb Compare September 7, 2023 19:47
@kimdv kimdv force-pushed the kimdv/2072-make-the-switch-over-keywords-in-tokenprecedenceswift-exhaustive branch from c7977eb to d0a0af7 Compare September 7, 2023 19:52
@kimdv kimdv force-pushed the kimdv/2072-make-the-switch-over-keywords-in-tokenprecedenceswift-exhaustive branch from d0a0af7 to ad8eba6 Compare September 7, 2023 20:21
@ahoppen
Copy link
Member

ahoppen commented Sep 7, 2023

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Sep 7, 2023

@swift-ci Please test Windows

@kimdv kimdv merged commit a381b0d into swiftlang:main Sep 8, 2023
@kimdv kimdv deleted the kimdv/2072-make-the-switch-over-keywords-in-tokenprecedenceswift-exhaustive branch September 8, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the switch over Keywords in TokenPrecedence.swift exhaustive
2 participants
@kimdv @ahoppen