Fix macro expansion diagnostic for multi-binding variable declarations in MacroSystem #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Would you mind also creating a second PR that targets the |
gohanlon
added a commit
to gohanlon/swift-syntax
that referenced
this pull request
Sep 1, 2023
--- Fix macro expansion diagnostic for multi-binding variable declarations in MacroSystem When there are no macro attributes attached to the visited `VariableDeclSyntax` node, proceed without performing any additional checks or transformations. - Addressed the erroneous triggering of `MacroApplicationError.accessorMacroOnVariableWithMultipleBindings` diagnostic for nested multi-binding variable declarations. - Added corresponding tests to validate the fix. - Introduce fileprivate `NoOpMemberMacro`, extracted from `testCommentAroundeAttachedMacro` and used in 2 new tests. Fixes swiftlang#2133 rdar://114836887
gohanlon
added a commit
to gohanlon/swift-syntax
that referenced
this pull request
Sep 1, 2023
--- Fix macro expansion diagnostic for multi-binding variable declarations in MacroSystem When there are no macro attributes attached to the visited `VariableDeclSyntax` node, proceed without performing any additional checks or transformations. - Addressed the erroneous triggering of `MacroApplicationError.accessorMacroOnVariableWithMultipleBindings` diagnostic for nested multi-binding variable declarations. - Added corresponding tests to validate the fix. - Introduce fileprivate `NoOpMemberMacro`, extracted from `testCommentAroundeAttachedMacro` and used in 2 new tests. Fixes swiftlang#2133 rdar://114836887
Done, see #2141. |
|
It looks like your changes are not formatted using |
gohanlon
added a commit
to gohanlon/swift-syntax
that referenced
this pull request
Sep 2, 2023
--- Fix macro expansion diagnostic for multi-binding variable declarations in MacroSystem When there are no macro attributes attached to the visited `VariableDeclSyntax` node, proceed without performing any additional checks or transformations. - Addressed the erroneous triggering of `MacroApplicationError.accessorMacroOnVariableWithMultipleBindings` diagnostic for nested multi-binding variable declarations. - Added corresponding tests to validate the fix. - Introduce fileprivate `NoOpMemberMacro`, extracted from `testCommentAroundeAttachedMacro` and used in 2 new tests. Fixes swiftlang#2133 rdar://114836887
…s in MacroSystem When there are no macro attributes attached to the visited `VariableDeclSyntax` node, proceed without performing any additional checks or transformations. - Addressed the erroneous triggering of `MacroApplicationError.accessorMacroOnVariableWithMultipleBindings` diagnostic for nested multi-binding variable declarations. - Added corresponding tests to validate the fix. - Introduce fileprivate `NoOpMemberMacro`, extracted from `testCommentAroundeAttachedMacro` and used in 2 new tests. Fixes swiftlang#2133 rdar://114836887
auto-merge was automatically disabled
September 2, 2023 05:17
Head branch was pushed to by a user without write access
gohanlon
force-pushed
the
fix-leaky-diagnostic
branch
from
983c3d9 to
b8e3122
Compare
|
Thank you! |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no macro attributes attached to the visited
VariableDeclSyntaxnode, proceed without performing any additional checks or transformations.MacroApplicationError.accessorMacroOnVariableWithMultipleBindingsdiagnostic for nested multi-binding variable declarations.NoOpMemberMacro, extracted fromtestCommentAroundeAttachedMacroand used in 2 new tests.Fixes #2133
rdar://114836887