Rename some properties on FreestandingMacroExpansionSyntax
#2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
I love the phrase "before the big rename"! 💙 |
Matejkob
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Do I see correctly that you've manually changed this code? Why not update the FreestandingMacroExpansion trait in CodeGeneration?
There was a problem hiding this comment.
Because I didn’t realize the trait was generated when I did this.
There was a problem hiding this comment.
Ah, no worries, happens to the best of us!
The requirements of `FreestandingMacroExpansionSyntax` still referred to the names of these properties before the big rename. Perform the same rename that we did on `MacroExpansionExprSyntax` on `FreestandingMacroExpansionSyntax`.
ahoppen
force-pushed
the
ahoppen/macroexpansion-renames
branch
from
2e23ffc to
a16fd42
Compare
|
@swift-ci Please test |
|
@swift-ci please test windows |
bnbarham
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The requirements of
FreestandingMacroExpansionSyntaxstill referred to the names of these properties before the big rename. Perform the same rename that we did onMacroExpansionExprSyntaxonFreestandingMacroExpansionSyntax.