Fold operators using the standard operator table in MacroSystem
#2132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/fold-operators
branch
from
6f7ffe4 to
565b396
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Sep 5, 2023
| in context: MacroExpansionContext, | ||
| foldingWith operatorTable: OperatorTable? | ||
| ) -> Self { | ||
| return (detach(in: context, foldingWith: operatorTable) as Syntax).cast(Self.self) |
There was a problem hiding this comment.
Suggested change
| return (detach(in: context, foldingWith: operatorTable) as Syntax).cast(Self.self) | |
| return (detach(in: context, foldingWith: operatorTable) as Syntax).cast(Self.self) |
What's the as needed for here? Doesn't this already return a Syntax?
There was a problem hiding this comment.
It’s to disambiguate the version of detach that is being called. Without as Syntax we would have an infinite recursion here.
ahoppen
force-pushed
the
ahoppen/fold-operators
branch
from
565b396 to
0af1cb8
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
The compiler folds operators in attributes and freestanding macro nodes but `MacroSystem` wasn’t doing that. But it should to match the compiler behavior. rdar://114786803 Fixes swiftlang#2128
ahoppen
force-pushed
the
ahoppen/fold-operators
branch
from
0af1cb8 to
12c0887
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler folds operators in attributes and freestanding macro nodes but
MacroSystemwasn’t doing that. But it should to match the compiler behavior.rdar://114786803
Fixes #2128