Remove unnecessary casts in SyntaxRewriter #2119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natikgadzhi
commented
Aug 30, 2023
| @@ -23,11 +23,11 @@ | |||
|
|
|||
| open class SyntaxRewriter { | |||
| public let viewMode: SyntaxTreeViewMode | |||
|
|
|||
There was a problem hiding this comment.
Oh, a lot of these is just swift-format 508.0.1.
There was a problem hiding this comment.
swift-format doesn't format generated code, so I think something went awry during the code generation process. Would you mind re-running the code generation to try to fix it?
|
Thank you, @natikgadzhi, for working on this! ❤️ |
|
I ran swift-format format Sources/SwiftSyntax/generated/SyntaxRewriter.swift —in-place manually.
Happy to generate without formatting through — my bad, I should have just ran format.py
|
natikgadzhi
force-pushed
the
natikgadzhi/syntax-rewriter-refactor-cast
branch
from
359d684 to
6bfac1e
Compare
|
There! Much cleaner now. |
ahoppen
approved these changes
Aug 30, 2023
We don’t manually format the generated files because the formatting will disappear the next time that you re-run CodeGeneration, which makes it hard to spot the modifications made by CodeGeneration. |
|
@swift-ci Please test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes unnecessary casts in
SyntaxRewriter, i.e. funcs that look like this:become this:
It's more readable, and
visitChildren(node)is guaranteed to return the same type asnodeanyway, so the cast is unnecessary. Thank you, @Matejkob, for filing the issue with pointers on how to get started!Closes #2102.
Disclaimer: I'm here to learn, and just making my first steps. Please feel free to "well, actually" me.
TODOs
SyntaxVisitor.visitand pretty deep. But, they also crash for me on main. 👀