Small refactoring improvements around ExprFlavor
#2103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/expr-flavor-refactoring
branch
from
075ba1a to
2054b60
Compare
Rename - `basic` -> `stmtCondition` because this case is used primarily in statement conditions that need to disambiguate trailing closures from the statement’s body - `trailingClosure` -> `basic` because this is the base case that we use inside normal expression parsing Also add argument labels to `flavor` to match the `pattern` parameter that also has a label and make `parseExpression` parameters required so that each caller needs to make a conscious choice about the values and so it’s easier to search for where each of the flavors is being used.
ahoppen
force-pushed
the
ahoppen/expr-flavor-refactoring
branch
from
2054b60 to
536fd81
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
kimdv
approved these changes
Aug 29, 2023
bnbarham
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forDirectivewithExprFlavor, getting rid of one boolean parameter in expression parsingExprFlavor.basic->stmtConditionbecause this case is used primarily in statement conditions that need to disambiguate trailing closures from the statement’s bodyExprFlavor.trailingClosure->basicbecause this is the base case that we use inside normal expression parsingflavorto match thepatternparameter that also has a label and makeparseExpressionparameters required so that each caller needs to make a conscious choice about the values and so it’s easier to search for where each of the flavors is being used.