[CMake] Add padding to RUNPATH in linux #2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shared libraries RUNPATH will be updated when they are copied to swift build directory. CMake's 'file(SET_RPATH ...)' requires RUNPATH field have enough lengh before updating.
rintaro
changed the title
|
@swift-ci Please test |
rintaro
changed the title
bnbarham
approved these changes
Aug 28, 2023
| elseif (CMAKE_SYSTEM_NAME STREQUAL Linux) | ||
| # Make some room to update paths. | ||
| set_property(TARGET ${name} APPEND PROPERTY | ||
| INSTALL_RPATH ":::::::::::::::::::::::::::::::::::::::::::::::::::::::") |
There was a problem hiding this comment.
Is this enough to cover all the platforms we know of?
There was a problem hiding this comment.
It's will be changed to $ORIGIN:$ORIGIN/../{platform name}. Yes, I don't believe any platform name would be longer than 45 characters.
There was a problem hiding this comment.
🤔 I thought I made it : x 64 but this is actually 55. Anyway 36 characters for platform name should be enough :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared libraries RUNPATH will be updated when they are copied to swift build directory. CMake's 'file(SET_RPATH ...)' requires RUNPATH field have enough lengh before updating.