Skip to content

Improve modeling of TokenSpec in CodeGeneration #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

Matejkob
Copy link
Contributor

Resolves part of #1977

@Matejkob Matejkob requested a review from ahoppen as a code owner August 16, 2023 16:19
@Matejkob Matejkob force-pushed the improve-TokenSpec-modeling branch from dc3dbab to b0ccdd2 Compare August 16, 2023 16:21
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM. And thanks for writing those doc comments as well.

@Matejkob Matejkob force-pushed the improve-TokenSpec-modeling branch from b0ccdd2 to f2e3d4d Compare August 16, 2023 19:40
@ahoppen
Copy link
Member

ahoppen commented Aug 16, 2023

@swift-ci Please test

@Matejkob Matejkob force-pushed the improve-TokenSpec-modeling branch from f2e3d4d to a022a1a Compare August 17, 2023 08:56
@Matejkob
Copy link
Contributor Author

Somehow I've missed one usage of raw: text. I've just pushed fix

@kimdv
Copy link
Contributor

kimdv commented Aug 17, 2023

@swift-ci please test

@kimdv
Copy link
Contributor

kimdv commented Aug 17, 2023

@swift-ci please test windows

@ahoppen ahoppen merged commit 1a38c3a into swiftlang:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants