Add documentation on pattern bindings #2035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another area that’s not super obvious. Add some documentation that hopefully sheds some light into why pattern bindings exist and what thye do.
|
@swift-ci Please test |
bnbarham
approved these changes
Aug 9, 2023
| documentation: """ | ||
| Declaration of one or more variables | ||
|
|
||
| The core of a variable declaration consists of a binding specifier (`let` or `var), |
There was a problem hiding this comment.
Suggested change
| The core of a variable declaration consists of a binding specifier (`let` or `var), | |
| The core of a variable declaration consists of a binding specifier (`let` or `var`), |
| initializers and accessors. | ||
|
|
||
| A variable declaration can contain multiple pattern bindings, because it’s possible | ||
| to define multiple variables after a single `let` keyword as follows. |
There was a problem hiding this comment.
I'd drop the as follows. Or use eg/, for example.
ahoppen
force-pushed
the
ahoppen/binding-documentation
branch
from
4a52604 to
9aa3d0a
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
kimdv
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another area that’s not super obvious. Add some documentation that hopefully sheds some light into why pattern bindings exist and what they do.
And also improve documentation of
AttributeSyntax.arguments.